tarball: pass imageToTags#1563
Merged
imjasonh merged 2 commits intogoogle:mainfrom Feb 9, 2023
Merged
Conversation
imjasonh
approved these changes
Feb 9, 2023
Contributor
|
Thanks! |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1563 +/- ##
==========================================
- Coverage 72.97% 72.95% -0.02%
==========================================
Files 118 118
Lines 9420 9417 -3
==========================================
- Hits 6874 6870 -4
- Misses 1854 1855 +1
Partials 692 692 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
tarball.MultiWrite(), themap[name.Reference]v1.Imageis inverted to amap[v1.Image][]stringby 3 independent helpers. This PR modifies to invert the map once, then pass the result between helpers.I'd made this change as part of a failed attempt at
tarball.WriteIndex()- I realize now why that was a bad idea, but this snippet seemed worth saving.