Retry ECONNRESET errors (#1415)

jonjohnsonjr · web-flow · commit 19e3eff70270 · 2022-07-22T17:35:01.000-04:00
We see this often as "connection reset by peer" errors. Not a lot we can
do about this beyond retrying.
diff --git a/pkg/v1/remote/options.go b/pkg/v1/remote/options.go
@@ -59,7 +59,7 @@ type Backoff = retry.Backoff
 var defaultRetryPredicate retry.Predicate = func(err error) bool {
 	// Various failure modes here, as we're often reading from and writing to
 	// the network.
-	if retry.IsTemporary(err) || errors.Is(err, io.ErrUnexpectedEOF) || errors.Is(err, io.EOF) || errors.Is(err, syscall.EPIPE) {
+	if retry.IsTemporary(err) || errors.Is(err, io.ErrUnexpectedEOF) || errors.Is(err, io.EOF) || errors.Is(err, syscall.EPIPE) || errors.Is(err, syscall.ECONNRESET) {
 		logs.Warn.Printf("retrying %v", err)
 		return true
 	}

Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,7 @@ type Backoff = retry.Backoff`
`59`	`59`	`var defaultRetryPredicate retry.Predicate = func(err error) bool {`
`60`	`60`	`// Various failure modes here, as we're often reading from and writing to`
`61`	`61`	`// the network.`
`62`		`- if retry.IsTemporary(err) \|\| errors.Is(err, io.ErrUnexpectedEOF) \|\| errors.Is(err, io.EOF) \|\| errors.Is(err, syscall.EPIPE) {`
	`62`	`+ if retry.IsTemporary(err) \|\| errors.Is(err, io.ErrUnexpectedEOF) \|\| errors.Is(err, io.EOF) \|\| errors.Is(err, syscall.EPIPE) \|\| errors.Is(err, syscall.ECONNRESET) {`
`63`	`63`	`logs.Warn.Printf("retrying %v", err)`
`64`	`64`	`return true`
`65`	`65`	`}`