Enforce proper sha256 usage (#1544)

howardjohn · web-flow · commit 11843ba2d084 · 2023-01-26T03:02:50.000-05:00
diff --git a/.golangci.yaml b/.golangci.yaml
@@ -32,3 +32,9 @@ linters:
 
   disable:
   - errcheck
+
+linters-settings:
+  depguard:
+    include-go-root: true
+    packages-with-error-message:
+    - crypto/sha256: "use crypto.SHA256 instead"
diff --git a/pkg/name/digest.go b/pkg/name/digest.go
@@ -15,6 +15,7 @@
 package name
 
 import (
+	// nolint: depguard
 	_ "crypto/sha256" // Recommended by go-digest.
 	"strings"
 
diff --git a/pkg/registry/registry_test.go b/pkg/registry/registry_test.go
@@ -15,7 +15,6 @@
 package registry_test
 
 import (
-	"bytes"
 	"fmt"
 	"io"
 	"log"
@@ -47,7 +46,7 @@ const (
 )
 
 func sha256String(s string) string {
-	h, _, _ := v1.SHA256(bytes.NewReader([]byte(s)))
+	h, _, _ := v1.SHA256(strings.NewReader(s))
 	return h.Hex
 }
 

Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,6 @@`
`15`	`15`	`package registry_test`
`16`	`16`
`17`	`17`	`import (`
`18`		`- "bytes"`
`19`	`18`	`"fmt"`
`20`	`19`	`"io"`
`21`	`20`	`"log"`
`@@ -47,7 +46,7 @@ const (`
`47`	`46`	`)`
`48`	`47`
`49`	`48`	`func sha256String(s string) string {`
`50`		`- h, _, _ := v1.SHA256(bytes.NewReader([]byte(s)))`
	`49`	`+ h, _, _ := v1.SHA256(strings.NewReader(s))`
`51`	`50`	`return h.Hex`
`52`	`51`	`}`
`53`	`52`