Add getSymbols(Predicate, LookupKind) compatibility method#2629
Closed
fawind wants to merge 1 commit intogoogle:masterfrom
Closed
Add getSymbols(Predicate, LookupKind) compatibility method#2629fawind wants to merge 1 commit intogoogle:masterfrom
getSymbols(Predicate, LookupKind) compatibility method#2629fawind wants to merge 1 commit intogoogle:masterfrom
Conversation
getSymbols(Predicate, LookupKind) compatibility method
cushon
approved these changes
Oct 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a compatibility helper method for
getSymbols(Predicate<Symbol>, LookupKind).Context:
In gradle-baseline, we maintain our own set of error-prone rules and ran into similar JDK 17 compatibility problems as mentioned in #2330.
However for our custom rules, we also need a compatibility helper for
getSymbols(Predicate, LookupKind). For now, we work around this by copying parts of theErrorProneScopeclass (PR) but ideally we could reuse the existing helper and wouldn't have to maintain our own fork of this class.