Skip to content

Fix Issue 2393#2470

Closed
openamiguel wants to merge 2 commits intogoogle:masterfrom
openamiguel:master
Closed

Fix Issue 2393#2470
openamiguel wants to merge 2 commits intogoogle:masterfrom
openamiguel:master

Conversation

@openamiguel
Copy link
Copy Markdown
Contributor

Fix for Issue #2393 (WrongOneof mishandles new style switch statement) based on PR #2371 and PR #2124.

@google-cla
Copy link
Copy Markdown

google-cla Bot commented Jul 27, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla Bot added the cla: no label Jul 27, 2021
@openamiguel
Copy link
Copy Markdown
Contributor Author

@googlebot I signed it!

@google-cla google-cla Bot added cla: yes and removed cla: no labels Jul 28, 2021
Copy link
Copy Markdown
Collaborator

@cushon cushon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Can you also add a test?

@openamiguel
Copy link
Copy Markdown
Contributor Author

Sure. There isn't any WrongOneofTest currently. Can I just focus on testing that this bug pattern works on new-style switch statements?

@cushon
Copy link
Copy Markdown
Collaborator

cushon commented Jul 30, 2021

There isn't any WrongOneofTest currently. Can I just focus on testing that this bug pattern works on new-style switch statements?

Sorry, we have an internal test for this, but it isn't available in open source to avoid the proto dependency in the maven build. Since there isn't already an existing test, this is fine.

@openamiguel
Copy link
Copy Markdown
Contributor Author

@cushon thanks for the approval! Are we waiting for additional review?

@cushon
Copy link
Copy Markdown
Collaborator

cushon commented Aug 6, 2021

Are we waiting for additional review?

Yes, there's a separate internal review step before the PR is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants