Fix Issue 2393#2470
Conversation
Update WrongOneof.java
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
@googlebot I signed it! |
cushon
left a comment
There was a problem hiding this comment.
Thanks for the fix! Can you also add a test?
|
Sure. There isn't any WrongOneofTest currently. Can I just focus on testing that this bug pattern works on new-style switch statements? |
Sorry, we have an internal test for this, but it isn't available in open source to avoid the proto dependency in the maven build. Since there isn't already an existing test, this is fine. |
|
@cushon thanks for the approval! Are we waiting for additional review? |
Yes, there's a separate internal review step before the PR is merged |
Fix for Issue #2393 (WrongOneof mishandles new style switch statement) based on PR #2371 and PR #2124.