Bump go versions to 1.18+#203
Merged
pohly merged 2 commits intogo-logr:masterfrom Aug 5, 2023
Merged
Conversation
pohly
reviewed
Aug 4, 2023
Contributor
pohly
left a comment
There was a problem hiding this comment.
Should we do a search/replace for s/interface{}/any/, either in this PR or a separate one?
Or do we transition organically as code using interface{} gets touched?
Personally I prefer a global search/replace to keep the code base consistent.
Contributor
Author
|
Good idea, new commit added |
pohly
approved these changes
Aug 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #202