This repository was archived by the owner on Nov 20, 2023. It is now read-only.
feat: adds pipeline argument#403
Merged
scefali merged 3 commits intogetsentry:masterfrom Oct 27, 2022
Merged
Conversation
Member
There was a problem hiding this comment.
This may just be my unfamiliarity with the way in which this is being used, but the nomenclature is a little confusing to me. Don't user agents normally include the version of the thing being the agent, not the subject of the agent's actions? And in what sense is this a pipeline?
UPDATE: Took a look at the GHA link, and yes, it should be the version of the doer, i.e., the version of @sentry/webpack-plugin, not the version of the code being packed up. You can get the correct version from package.json the same way the GHA code does.
kamilogorek
approved these changes
Oct 27, 2022
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR set the
SENTRY_PIPELINEenv variable so we can set the user agent here: https://github.com/getsentry/sentry-cli/blob/6f9173687fdfd56810145c5c727ff76978784814/src/api.rsThis approach was taken from Github actions: https://github.com/getsentry/action-release/blob/master/src/cli.ts#L13