fix: Support process v0 symbols in stack traces#525
Merged
Conversation
kamilogorek
reviewed
Nov 28, 2022
kamilogorek
approved these changes
Nov 28, 2022
Co-authored-by: Kamil Ogórek <kamil.ogorek@gmail.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #525 +/- ##
==========================================
+ Coverage 78.68% 78.76% +0.08%
==========================================
Files 77 77
Lines 9279 9316 +37
==========================================
+ Hits 7301 7338 +37
Misses 1978 1978 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will now correctly strip the crate hash from new v0 mangled symbols.
We may need to do the same in sentry itself when cleaning symbols that come from serverside symbolication.
fixes #520