fix(browser): Check for existence of instrumentation targets#8939
Merged
Lms24 merged 4 commits intogetsentry:developfrom Sep 5, 2023
SorsOps:develop
Merged
fix(browser): Check for existence of instrumentation targets#8939Lms24 merged 4 commits intogetsentry:developfrom SorsOps:develop
Lms24 merged 4 commits intogetsentry:developfrom
SorsOps:develop
Conversation
lforst
approved these changes
Sep 4, 2023
Lms24
approved these changes
Sep 5, 2023
Member
Lms24
left a comment
There was a problem hiding this comment.
Thanks for opening this PR! LGTM.
Lms24
reviewed
Sep 5, 2023
| function instrumentXHR(): void { | ||
| if (!('XMLHttpRequest' in WINDOW)) { | ||
| export function instrumentXHR(): void { | ||
| if (!(WINDOW as any).XMLHttpRequest) { |
Member
There was a problem hiding this comment.
q: Why do we need the typecast to any here? Or IOW why do we need it here and not in WINDOW.document below?
Member
There was a problem hiding this comment.
ignore this, just learned that it's not in WINDOW. Makes sense!
Member
|
Btw, our linter ( If there's no way around it, feel free to disable the rule for this line. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request, please take a look at our
Contributing guidelines and verify:
yarn lint) & (yarn test).Description
There are cases when global objects such as the window object are shimmed that they define properties such as
document, but the actual value is undefined. This exact situation has been occurring and is causing the instrumentDOM function to throw an error as'document' in WINDOWis technically true though the value is falsey. We should rather attempt an actual check of the value being truthy rather than if the property is defined