ref: Use consistent console instrumentation#8879
Conversation
size-limit report 📦
|
| /** | ||
| * @inheritDoc | ||
| */ | ||
| public setupOnce(_: (callback: EventProcessor) => void, getCurrentHub: () => Hub): void { |
There was a problem hiding this comment.
Let's not change the signature of this. This integration is part of the public API.
There was a problem hiding this comment.
I think this should be fine for an API as any caller can still pass in anything that you passed into it previously (it accepts more, not less), but I can leave it as is for sure.
There was a problem hiding this comment.
If there's no reason to widen the API let's not do it.
790250f to
7c8586d
Compare
AbhiPrasad
left a comment
There was a problem hiding this comment.
I wonder if using a Proxy will help remove the fact that our current console instrumentation overrides the filename that is displayed in the console.
I guess we can look at that for v8, maybe? Or have two implementations, but that is a bit bloaty 🤔 |
While looking into logger issues, I noticed that we fill console.xxx multiple times. This PR changes that so that we use the console instrumentation from utils in all cases.