feat(node-experimental): Sync OTEL context with Sentry AsyncContext#8797
Merged
feat(node-experimental): Sync OTEL context with Sentry AsyncContext#8797
Conversation
Contributor
size-limit report 📦
|
dc30b4d to
09aca72
Compare
3 tasks
09aca72 to
94cfae2
Compare
AbhiPrasad
approved these changes
Aug 31, 2023
| return getHubFromCarrier(carrier); | ||
| } | ||
|
|
||
| /** TODO docs */ |
Contributor
There was a problem hiding this comment.
l: shall we add them now, or wait till after?
Member
Author
There was a problem hiding this comment.
Good point, will add a little bit of docs!
94cfae2 to
b111b97
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements a strategy to sync the OpenTelemetry Context with our own Hub forking for AsyncContext.
This works by fully relying on OpenTelemetry to handle async context isolation/forking.
This means we do not need to do any context forking ourselves anymore, so no need for e.g.
Sentry.Handlers.requestHandler()and stuff like this.It should also mean that Sentry & OTEL should be as in sync as possible.
Some notes: