Conversation
Contributor
size-limit report 📦
|
AbhiPrasad
reviewed
Aug 9, 2023
Contributor
AbhiPrasad
left a comment
There was a problem hiding this comment.
Adding origin to a transaction does nothing atm right?
Lms24
approved these changes
Aug 10, 2023
Member
Lms24
left a comment
There was a problem hiding this comment.
Adjusted the origins of all packages (mostly navigation and pageload ops)
| this.data = spanContext.data || {}; | ||
| this.instrumenter = spanContext.instrumenter || 'sentry'; | ||
| this.origin = spanContext.origin || 'manual'; | ||
|
|
Member
There was a problem hiding this comment.
l: (or no action required) we might wanna streamline some of the other assignments here as well but it's ouf of scope for this PR. feel free to ignore
Member
Author
It's not shown anywhere at least, as far as I can tell! |
AbhiPrasad
approved these changes
Aug 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an
originto all spans, which defaults tomanualbut is set to something more meaningful for all our auto instrumentation.I tried to come up with reasonable origin names, I hope it makes sense everywhere 😅 Also note that this now uses a new TS feature which seems to be correctly transpiled to TS 3.8, as far as I can tell! 🎉
Closes #8510