feat(tracing): Add tracing without performance to browser and client Sveltekit#8458
Merged
AbhiPrasad merged 4 commits intodevelopfrom Jul 6, 2023
Merged
feat(tracing): Add tracing without performance to browser and client Sveltekit#8458AbhiPrasad merged 4 commits intodevelopfrom
AbhiPrasad merged 4 commits intodevelopfrom
Conversation
Contributor
size-limit report 📦
|
Lms24
approved these changes
Jul 6, 2023
Member
Lms24
left a comment
There was a problem hiding this comment.
Nice, LGTM!
(Fwiw, we might be able to get rid of the additional SvelteKit fetch instrumentation after all. Someone recently pointed out how they managed to instrument window.fetch before Kit. I'll give this a try when I find the time for it but for now this looks good!)
AbhiPrasad
added a commit
that referenced
this pull request
Jul 6, 2023
…Sveltekit (#8458) Adds tracing without performance support to 1. fetch requests in browser 2. xhr requests in browser 3. Sveltekit fetch monkeypatching (pulled into this PR because it also uses `addTracingHeadersToFetchRequest`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref #8352
Adds tracing without performance support to
addTracingHeadersToFetchRequest