Skip to content

feat(nextjs): Add automatic monitors for Vercel Cron Jobs#8088

Merged
lforst merged 9 commits intodevelopfrom
lforst-auto-crons
May 10, 2023
Merged

feat(nextjs): Add automatic monitors for Vercel Cron Jobs#8088
lforst merged 9 commits intodevelopfrom
lforst-auto-crons

Conversation

@lforst
Copy link
Copy Markdown
Contributor

@lforst lforst commented May 9, 2023

No description provided.

@lforst lforst requested review from AbhiPrasad, Lms24 and mydea May 10, 2023 08:08
logger.info(
`${chalk.cyan(
'info',
)} - Creating Sentry cron monitors for your Vercel Cron Jobs. You can disable this feature by setting the ${chalk.bold.cyan(
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

m: Should we only log this out if the crons field is defined? Otherwise I can see how this might get confusing

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point!

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

status: 'in_progress',
},
{
checkinMargin: 2, // two minutes - in case Vercel has a blip
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did we remove this?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a discussion with the crons team. The missed checkins were a bug in the product when the margin is set to 0.

Co-authored-by: Abhijeet Prasad <aprasad@sentry.io>
Luca Forstner and others added 2 commits May 10, 2023 14:41
Copy link
Copy Markdown
Contributor

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kitty-cat-sandwich

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants