fix(replay): Ensure we still truncate large bodies if they are failed JSON#7923
Merged
fix(replay): Ensure we still truncate large bodies if they are failed JSON#7923
Conversation
Lms24
approved these changes
Apr 20, 2023
Member
Author
|
cc @ryan953 so you are aware which combinations of warnings are possible:
|
Contributor
size-limit report 📦
|
… JSON Also add some tests around this.
2f77f5d to
2fadd5a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also incorporates feedback from @Lms24 to properly handle the case when we both fail to parse JSON AND still truncate the body.