fix(replay): Ensure console breadcrumb args are truncated#7917
Merged
fix(replay): Ensure console breadcrumb args are truncated#7917
Conversation
Contributor
size-limit report 📦
|
454a756 to
ad13981
Compare
billyvg
approved these changes
Apr 20, 2023
ad13981 to
8295ecb
Compare
AbhiPrasad
approved these changes
Apr 21, 2023
1a8f4a9 to
d2a86c5
Compare
8c578be to
6548ac9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses the new
fixJsonutil to also truncate console log breadcrumbs for replay.It adds a
data._meta.warnings = ['CONSOLE_ARG_TRUNCATED']to the breadcrumb if it has truncated at least one arg.I also added a test that fails before this PR - it logs a massive object to the console, which leads to the test timing out previously, but works with this change.
Closes #7677
ref https://github.com/getsentry/team-replay/issues/67