fix(sveltekit): Detect sentry release before creating the Vite plugin#7902
Merged
fix(sveltekit): Detect sentry release before creating the Vite plugin#7902
Conversation
274511f to
9243382
Compare
Contributor
size-limit report 📦
|
lforst
approved these changes
Apr 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a SvelteKit production build, an error was thrown if the sentry-cli wasn't able to detect a release (for instance because the project is not in a git repo). This PR fixes this by detecting a release value before creating the plugin. The detection mechanism is identical to the mechanism in the NextJS SDK, with the exception of the fallback:
In NextJS, we just fall back to Next's internal build id. SvelteKit doesn't have such an Id, which is why ultimately, we just generate a UUID instead. However, I'd argue we want to first attempt detecting a commit hash as it is less random and the Sentry CLI does it as well.