feat(sveltekit): Add Sentry Vite Plugin to upload source maps#7811
Merged
feat(sveltekit): Add Sentry Vite Plugin to upload source maps#7811
Conversation
AbhiPrasad
reviewed
Apr 11, 2023
lforst
approved these changes
Apr 12, 2023
This was referenced Apr 12, 2023
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a customized version of the Sentry Vite plugin to the SvelteKit SDK.
After realizing that the proposed API in #7787 doesn't work as I originally thought, this PR also re-reworks it a little bit:
The customized Vite plugin differs from the Vite plugin as follows:
enforce: 'post'closeBundlehook instead of thewriteBundlehook to upload source maps.configurehook to enable source map generationsorcerydoes) to work around weird source maps generation behaviour.Also:
ref #7669