Ah, just noticed I still have some domain usages to remove from serverless!

node sdk index is now side effect free :)

This makes me so happy :)

Speaking of, @timfish would you mind adding a "sideEffects": false to the node SDK's package.json? That will make it tree shakable by webpack. (Not that important but some serverless folks care about bundle size)

Ah, just noticed I still have some domain usages to remove from serverless!

We also need to adjust the test in packages/node/test/manual/webpack-domain/index.js

We also need to adjust the test in packages/node/test/manual/webpack-domain/index.js

Should we be re-exporting runWithAsyncContext from @sentry/node to make this possible?

We also need to adjust the test in packages/node/test/manual/webpack-domain/index.js

Should we be re-exporting runWithAsyncContext from @sentry/node to make this possible?

Shouldn't we be exporting this API everywhere? Doesn't have to be right now but at some point I think we should, right?

We also need to adjust the test in packages/node/test/manual/webpack-domain/index.js

Should we be re-exporting runWithAsyncContext from @sentry/node to make this possible?

Yup we'll need to re-export this API, since this is how we are going to tell people to do isolation when they manually instrument.

Yup we'll need to re-export this API

I might change the name of the args option before we export and document this!

Oh realized we didn't do the package.json change here, will open up a PR for that!

And this is why you don't do early morning code review 😭 - it is there, just skipped the file completely!