Conversation
Closed
3 tasks
Collaborator
|
I would need to test if it works but we might be be able to get the inference working for This is non-breaking since the generic has a default: type BrowserOptions<TO extends BaseTransportOptions = BrowserTransportOptions> = Options<TO> & BrowserClientReplayOptions;function init<TO = BrowserTransportOptions>(options: BrowserOptions<TO>) { |
Collaborator
Oh no, it's seems much more complicated and not a simple fix... |
Member
Author
|
Yeah I tried your suggestion but got type errors all over the place 😅 I'd say we go with this unless there are other concerns (happy to try something different though) |
timfish
approved these changes
Apr 6, 2023
Collaborator
timfish
left a comment
There was a problem hiding this comment.
Yeah, I think this is good for now!
AbhiPrasad
approved these changes
Apr 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As reported in #7766, our
transportOptionsinit field currently isn't typed correctly to acceptBrowserOfflineTransportOptions, causing type errors when trying to configure the offline transport. This PR fixes this bug by makingBrowserTransportOptionsextendBrowserOfflineTransportOptions.closes #7766