Conversation
Due to some weird
Lms24
approved these changes
Mar 21, 2023
Contributor
size-limit report 📦
|
|
This is still broken and not correctly outputting es5. Using are-you-es5. ❌ @sentry/browser is not ES5 "@sentry/browser": "7.44.2", |
Member
Author
|
This is only about the CDN bundles, not the NPM packages (which are-you-es5 checks, as far as I can tell?). If you are using the NPM modules, you have to take care of transpiling this to ES5 yourself! At least I haven't found a way to make are-you-es5 work with a CDN bundle? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to add packages to the ts plugin config, otherwise they are not correctly ES5 transpiled. I also added this to the checklist.
I will merge this PR into master and cut a release so we can do a bugfix release (there is already a feature on develop).
Closes #7541