feat(tracing): Expose BrowserTracing in non-tracing bundles#7479
Merged
feat(tracing): Expose BrowserTracing in non-tracing bundles#7479
BrowserTracing in non-tracing bundles#7479Conversation
AbhiPrasad
approved these changes
Mar 16, 2023
Lms24
approved these changes
Mar 16, 2023
rollup/plugins/bundlePlugins.js
Outdated
| ); | ||
|
|
||
| const browserIndexFilePath = path.resolve(__dirname, '../../packages/browser/src/index.ts'); | ||
| const browserIntegrationsIndexFilePath = path.resolve(__dirname, '../../packages/browser/src/integrations/index.ts'); |
Member
There was a problem hiding this comment.
l: Would you mind updating the JSDoc of this function? I think it's pretty outdated by now.
Member
Author
There was a problem hiding this comment.
actually got rid of this now!
In order to avoid breaking the bundler when a user opts out of tracing there.
ccc1043 to
f71eb69
Compare
Member
Author
|
So I updated this to make this work properly. |
AbhiPrasad
approved these changes
Mar 20, 2023
Contributor
size-limit report 📦
|
f71eb69 to
538ae59
Compare
Lms24
approved these changes
Mar 20, 2023
Member
Lms24
left a comment
There was a problem hiding this comment.
I agree, the separate index files look like the cleaner option now!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to avoid breaking the bundler when a user opts out of tracing there.