fix(serverless): Explicitly export node package exports#7457
Merged
AbhiPrasad merged 3 commits intodevelopfrom Mar 16, 2023
Merged
fix(serverless): Explicitly export node package exports#7457AbhiPrasad merged 3 commits intodevelopfrom
AbhiPrasad merged 3 commits intodevelopfrom
Conversation
3 tasks
Contributor
size-limit report 📦
|
3ba9213 to
e20c5db
Compare
Lms24
approved these changes
Mar 16, 2023
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #7441
A serverless package that is esm only breaks when trying to import our serverless package. This is because in our serverless we combine both wildcard and namespace exports. This confuses our rollup bundler, which causes it to put all of the wildcard exports (from
@sentry/node) intodefault, which means it is not exposed as a top level export.When users try to use the esm serverless package, they are unable to access exports like
captureExceptionorinit.The solution here is to just explicitly export everything from the
@sentry/nodepackage. In v8 we have to re-visit this and get rid of the namespace exports, since they don't serve much use, and mean that tree-shaking does not work.