fix(types): Fix node types & add E2E test#7429
Merged
AbhiPrasad merged 1 commit intodevelopfrom Mar 13, 2023
Merged
Conversation
Contributor
size-limit report 📦
|
mydea
commented
Mar 13, 2023
|
|
||
| "compilerOptions": { | ||
| // package-specific options | ||
| "lib": ["ES6"] |
Member
Author
There was a problem hiding this comment.
Note: This setting actually leads to the old code failing at build time, so this should also prevent this happening again for types, at least.
AbhiPrasad
approved these changes
Mar 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures we only export generic code from @sentry/types that works both in node & browser.
unknownin types - ensure to type this at call siteFixes #7422