feat(sveltekit): Add wrapper for server load function#7416
Merged
AbhiPrasad merged 6 commits intodevelopfrom Mar 14, 2023
Merged
feat(sveltekit): Add wrapper for server load function#7416AbhiPrasad merged 6 commits intodevelopfrom
AbhiPrasad merged 6 commits intodevelopfrom
Conversation
Contributor
size-limit report 📦
|
b2db998 to
e4aa3f4
Compare
e4aa3f4 to
afddce3
Compare
mydea
reviewed
Mar 14, 2023
| return new Proxy(origLoad, { | ||
| apply: async (wrappingTarget, thisArg, args: Parameters<ServerLoad>) => { | ||
| try { | ||
| return await wrappingTarget.apply(thisArg, args); |
Member
There was a problem hiding this comment.
should we do the same here as we just fixed in next, return the original promise, and do the capturing of errors separately?
Contributor
Author
There was a problem hiding this comment.
this is freaking cursed that this is even a possibility LOL
but yes we should 😞
mydea
approved these changes
Mar 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #7403
Add wrapper for server-side load function.
Also went ahead and fixed the mechanism type to beNvm I misunderstood, changed this decision.instrument, sincesveltekitis not an accepted value.Using Proxy for this which I assume is fine, but we can avoid using it if needed
Usage:
We also special case errors coming from the SvelteKit
errorhelper.If users defined a load function like so:
We would not capture that thrown error as it is a 404. In the future we can provide a way to opt-in to 4xx errors.