fix(core): Avoid using Array.findIndex() as it is ES5 incompatible#7400
Merged
fix(core): Avoid using Array.findIndex() as it is ES5 incompatible#7400
Array.findIndex() as it is ES5 incompatible#7400Conversation
3 tasks
lforst
approved these changes
Mar 10, 2023
Contributor
lforst
left a comment
There was a problem hiding this comment.
wondering if we should use something like browserlist....
Contributor
size-limit report 📦
|
Lms24
approved these changes
Mar 10, 2023
Member
Author
|
It would be nice to have an easy way to just use this and have a polyfill be added only for the ES5 bundle. But let's merge this for now and maybe look into this later! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure if there is an easy way to polyfill this only for ES5 builds? But other than this, this should be straightforward enough.
Closes #7397