feat: Ensure we use the same default environment everywhere#7327
Merged
feat: Ensure we use the same default environment everywhere#7327
environment everywhere#7327Conversation
lforst
approved these changes
Mar 3, 2023
Contributor
lforst
left a comment
There was a problem hiding this comment.
We just have to be aware that this can be somewhat breaking because people may have set up alerting rules based on environment but I think this is a good change in general.
Contributor
size-limit report 📦
|
Member
Author
Yeah, I though the same, not 100% sure, I'd tend towards is fine because it def. seems more like a bug/unexpected behavior. |
AbhiPrasad
approved these changes
Mar 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adjusts our code to use the same default environment everywhere in the codebase for consistency.
Currently, we use
productionsome places and''in others.I may have missed something, but tried to find all places using this.
Closes #6239