feat(nextjs): Connect traces for server components#7320
Merged
Conversation
AbhiPrasad
approved these changes
Mar 7, 2023
Contributor
AbhiPrasad
left a comment
There was a problem hiding this comment.
Would appreciate a screenshot in the PR!
Contributor
Author
@AbhiPrasad one for the history books:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7179
This PR adds connected traces to server components. One thing we have to be careful of is not to call
headers()during the build-phase, otherwise, Next.js will mark the wrapped server component as dynamic which will have a drastic performance impact for the user.Also, this PR adds some code to our E2E tests so we can assert on build output. In this case we wanna assert that static components stay static and dynamic ones dynamic.