fix(replay): Add CDN bundle path to release artifacts#6452
Merged
Conversation
AbhiPrasad
approved these changes
Dec 7, 2022
Co-authored-by: Abhijeet Prasad <aprasad@sentry.io>
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So, turns out, CDN bundles are not released automatically (I should have known...)
Craft uses the release artifacts zip generated by our "Upload Artifacts" job to search for files to upload. Our bundle path (
packages/replay/build/bundles) wasn't added to this job's config so it wasn't included in the release.This PR fixes that and it also adds an entry to our release checklist. It furthermore bumps the minimum version for the CDN bundles in the Replay README. Docs should automatically pick up the newest version, so we don't need to bump anything in getsentry/sentry-docs#5899
Note: I still think we don't need to add anything to the Craft config, as it seems like craft is picking up all JS files in the artifacts zip and uploads the to GCS