feat(nextjs): Parameterize prefix loader values#6377
Merged
lobsterkatie merged 6 commits intomasterfrom Dec 2, 2022
Merged
Conversation
b2c314a to
acef63c
Compare
Contributor
size-limit report 📦
|
lforst
approved these changes
Dec 2, 2022
Contributor
lforst
left a comment
There was a problem hiding this comment.
I am kinda starting to wonder whether our prefixLoader isn't just a glorified DefinePlugin but we can worry about that in the future.
Member
Author
|
I understand why you say that, but to be |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the
prefixLoaderwe use in the nextjs SDK to accept template name and replacement values as parameters, and pulls injection of that loader into a helper function. It also renames the current template fromprefixLoaderTemplatetoserverRewriteFramesPrefixLoaderTemplate, to better indicate its purpose and to distinguish it from future templates also using the prefix loader.