Skip to content

fix(node): Do not assert in vendored proxy code (v7 backport)#11009

Merged
Lms24 merged 1 commit intov7from
fix/remove-proxy-assert
Mar 11, 2024
Merged

fix(node): Do not assert in vendored proxy code (v7 backport)#11009
Lms24 merged 1 commit intov7from
fix/remove-proxy-assert

Conversation

@timfish
Copy link
Copy Markdown
Collaborator

@timfish timfish commented Mar 11, 2024

Closes #11002

@timfish timfish changed the title fix(node): Do not assert in vendored proxy code fix(node): Do not assert in vendored proxy code (v7 backport) Mar 11, 2024
@timfish timfish mentioned this pull request Mar 11, 2024
Merged
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 11, 2024

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 78.71 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 69.87 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 73.83 KB (0%)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 63.48 KB (0%)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 33.84 KB (0%)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 34.88 KB (+0.01% 🔺)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.44 KB (0%)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.45 KB (0%)
@sentry/browser - Webpack (gzipped) 22.68 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 76.98 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 68.4 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 34.2 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped) 25.11 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 215.54 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 103.35 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 75.38 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 37.38 KB (+0.02% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 70.25 KB (0%)
@sentry/react - Webpack (gzipped) 22.71 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 89.13 KB (+0.04% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 53.3 KB (+0.05% 🔺)
@sentry-internal/feedback - Webpack (gzipped) 17.28 KB (0%)

Lms24
Lms24 approved these changes Mar 11, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AbhiPrasad AbhiPrasad mentioned this pull request Mar 11, 2024
Closed
@Lms24 Lms24 merged commit df6f048 into v7 Mar 11, 2024
@Lms24 Lms24 deleted the fix/remove-proxy-assert branch March 11, 2024 15:43
This was referenced Mar 12, 2024
Merged
Closed
@Lms24 Lms24 mentioned this pull request Mar 20, 2024
Merged
@Lms24 Lms24 mentioned this pull request Apr 10, 2024
Merged
@Lms24 Lms24 mentioned this pull request May 31, 2024
Merged
This was referenced Jun 3, 2024
Closed
Merged
This was referenced Jun 4, 2024
Merged
Merged
@Lms24 Lms24 mentioned this pull request Jan 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lms24 Lms24 Lms24 approved these changes

+1 more reviewer

@lforst lforst lforst approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@timfish @lforst @Lms24