feat(sveltekit): Add custom browserTracingIntegration()#10450
Merged
Conversation
Contributor
size-limit report 📦
|
51bca08 to
97896f9
Compare
mydea
reviewed
Feb 2, 2024
mydea
reviewed
Feb 2, 2024
mydea
reviewed
Feb 2, 2024
| }), | ||
| }; | ||
|
|
||
| return { |
mydea
approved these changes
Feb 2, 2024
e555cd1 to
230e1f0
Compare
onurtemizkan
pushed a commit
that referenced
this pull request
Feb 4, 2024
Deprecates SvelteKit's `BrowserTracing` integration in favour of the new `browserTracingIntegration` functional integration. The new integration now also directly initializes the routing instrumentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR deprecates SvelteKit's
BrowserTracingintegration in favour of the newbrowserTracingIntegrationfunctional integration. The new integration now also directly initializes the routing instrumentation.In comparison to the old routing instrumentation, there are no significant changes other than making more use of attributes instead of tags and top-level origin.
Added unit tests for behavioural checks. E2E tests also test the new integration implicitly.
ref #10387