Skip to content

feat(remix): Export missing functions#10385

Merged
Lms24 merged 2 commits intodevelopfrom
lms/feat-remix-export-missing-functions
Jan 29, 2024
Merged

feat(remix): Export missing functions#10385
Lms24 merged 2 commits intodevelopfrom
lms/feat-remix-export-missing-functions

Conversation

@Lms24
Copy link
Copy Markdown
Member

@Lms24 Lms24 commented Jan 29, 2024 •
edited
Loading

Looks like we missed re-exporting a couple of recently added functions in the Remix SDK. This PR adds the missing exports:

  • addIntegration
  • getClient
  • getCurrentScope, getIsolationScope, getGlobalScope
  • setMeasurement
  • getActiveSpan
  • startSpan, startSpanManual, startInactiveSpan
  • continueTrace
  • isInitialized

closes #10384

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 29, 2024 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 77.93 KB (+0.07% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 69.13 KB (+0.1% 🔺)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 73.02 KB (+0.1% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 62.78 KB (+0.11% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 33.18 KB (+0.21% 🔺)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.32 KB (+0.13% 🔺)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.33 KB (+0.13% 🔺)
@sentry/browser - Webpack (gzipped) 22.6 KB (+0.28% 🔺)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 75.76 KB (+0.21% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 67.3 KB (+0.21% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 33.17 KB (+0.49% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 24.52 KB (+0.22% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 212.01 KB (+0.26% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 100.02 KB (+0.54% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 73.35 KB (+0.25% 🔺)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 36.26 KB (+0.43% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 69.54 KB (+0.09% 🔺)
@sentry/react - Webpack (gzipped) 22.63 KB (+0.24% 🔺)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 86.23 KB (+0.11% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 50.53 KB (+0.17% 🔺)
@sentry-internal/feedback - Webpack (gzipped) 17.21 KB (0%)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 33.07 KB (added)

mydea
mydea approved these changes Jan 29, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@mydea mydea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be nice to have some tests somewhere (?) and/or some code to make this easier - it's always super brittle to ensure you add a new function to all packages for re-exporting 😬

@Lms24
Copy link
Copy Markdown
Member Author

Lms24 commented Jan 29, 2024

would be nice to have some tests somewhere (?) and/or some code to make this easier

yeah I also thought about this. We can somewhat assert on these exports in e2e tests (e.g. import them where we call init and throw if they're undefined) but this also doesn't scale well. I have an idea for a script but still need to try it out.

@Lms24 Lms24 merged commit 0612090 into develop Jan 29, 2024
@Lms24 Lms24 deleted the lms/feat-remix-export-missing-functions branch January 29, 2024 09:16
This was referenced Jan 29, 2024
Closed
Merged
Merged
Merged
Lms24 added a commit that referenced this pull request Jan 30, 2024
@Lms24
feat(remix): Add more missing @sentry/node re-exports (#10391)
2267493 
Missed some exports in my manual pass in #10385. Test in #10389
discovered more missing exports which this PR adds or marks as
unnecessary in the re-export test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mydea mydea mydea approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Some functions are not available in @sentry/remix

2 participants

@Lms24 @mydea