Skip to content

fix: Ensure afterAllSetup is called when using addIntegration()#10372

Merged
mydea merged 2 commits intodevelopfrom
fn/fix-afterAllSetup
Jan 26, 2024
Merged

fix: Ensure afterAllSetup is called when using addIntegration()#10372
mydea merged 2 commits intodevelopfrom
fn/fix-afterAllSetup

Conversation

@mydea
Copy link
Copy Markdown
Member

@mydea mydea commented Jan 26, 2024

Noticed that this is not really correct right now!

@mydea mydea requested a review from AbhiPrasad January 26, 2024 17:22
@mydea mydea self-assigned this Jan 26, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 26, 2024

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 77.9 KB (+0.04% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 69.11 KB (+0.07% 🔺)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 73.01 KB (+0.08% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 62.75 KB (+0.06% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 33.15 KB (+0.13% 🔺)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.31 KB (+0.1% 🔺)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.32 KB (+0.1% 🔺)
@sentry/browser - Webpack (gzipped) 22.57 KB (+0.14% 🔺)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 75.73 KB (+0.16% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 67.29 KB (+0.19% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 33.13 KB (+0.38% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 24.5 KB (+0.13% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 211.95 KB (+0.23% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 99.96 KB (+0.48% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 73.28 KB (+0.16% 🔺)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 36.23 KB (+0.33% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 69.52 KB (+0.06% 🔺)
@sentry/react - Webpack (gzipped) 22.6 KB (+0.1% 🔺)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 86.2 KB (+0.07% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 50.51 KB (+0.14% 🔺)
@sentry-internal/feedback - Webpack (gzipped) 17.21 KB (0%)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 33.04 KB (added)

@mydea mydea enabled auto-merge (squash) January 26, 2024 19:06
@mydea mydea merged commit 9f9c51d into develop Jan 26, 2024
@mydea mydea deleted the fn/fix-afterAllSetup branch January 26, 2024 19:52
mydea added a commit that referenced this pull request Jan 30, 2024
)

Refactors the usage of `BrowserTracing()` for Ember.

There it is easy to refactor this because we do not expose this to the
user - we automatically add the browsertracing integration based on
configuration.

This depends on
#10372.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants