fix(nextjs): Fix Http integration type declaration#10338
Merged
Conversation
Contributor
size-limit report 📦
|
lforst
approved these changes
Jan 25, 2024
this didn't cause an error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some reason
const { Http: OriginalHttp } = Integrationscaused weirdness around getting type imports from the local build structure instead of importing the type top-level. This PR removes the object destructuring in favour of directly referencingIntegrations.Http.ref #10310 (comment)
(This is part of a couple of fixes we need to get out to fix currently broken type declarations)