feat(types): Deprecate op on Span interface#10217
Merged
Conversation
op to Span interfaceop on Span interface
AbhiPrasad
approved these changes
Jan 17, 2024
Contributor
size-limit report 📦
|
d3013db to
3558c2c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discovered during #10208, the
opproperty of theSpaninterface was still missing a deprecation becauseSpaninherited it fromSpanContextwhich I missed.Looks like all usages ofopwere covered already in #10189 so this is more or less only a formalityEDIT: Nope, definitely not all usages were already covered 😅 Added a bunch of parallel deprecation and replacement adjustments. Primarily in tests though, a couple of rewrites in code.