feat(core): Deprecate Span.spanRecorder#10199
Merged
Conversation
mydea
approved these changes
Jan 16, 2024
9b074a7 to
0ccc4b9
Compare
Contributor
size-limit report 📦
|
a1ffee4 to
8a8dee1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR deprecates the
spanRecorderfield on theSpanclass. For now there's no replacement yet. I'm not entirely sure how we're going to keep track of spans within the SDK. #9972 shows an alternative forIdleSpanwhich no longer seems to rely on thespanRecorder. Another possibility might be to make the recorder private which might be enough, too.Anyhow, we should deprecate the field in any case as it's not meant to be user facing and of course also doesn't exist on the Otel
Spaninterface.ref #10184