Skip to content

feat(core): Deprecate Transaction.setMeasurement in favor of setMeasurement#10182

Merged
Lms24 merged 2 commits intodevelopfrom
lms/feat-core-deprecate-transaction-setMeasurement
Jan 15, 2024
Merged

feat(core): Deprecate Transaction.setMeasurement in favor of setMeasurement#10182
Lms24 merged 2 commits intodevelopfrom
lms/feat-core-deprecate-transaction-setMeasurement

Conversation

@Lms24
Copy link
Copy Markdown
Member

@Lms24 Lms24 commented Jan 15, 2024

This PR deprecates the setMeasurement API on the transaction interface and class. It's replaced by an already existing top level setMeasurement function.

The actual replacement behaviour is TBD for v8 but for now we need to deprecate this method as it's not part of the Otel API.

@Lms24 Lms24 requested review from AbhiPrasad and mydea January 15, 2024 13:23
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 15, 2024

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 77.12 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 68.48 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 62.14 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 32.52 KB (+0.04% 🔺)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.09 KB (0%)
@sentry/browser - Webpack (gzipped) 22.44 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 74.8 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 66.45 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 32.28 KB (+0.04% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 24.09 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 209.47 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 97.53 KB (+0.05% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 72.08 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 35.3 KB (+0.05% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 68.86 KB (+0.03% 🔺)
@sentry/react - Webpack (gzipped) 22.48 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 85.55 KB (+0.02% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 49.66 KB (+0.03% 🔺)
@sentry-internal/feedback - Webpack (gzipped) 17.11 KB (0%)

@Lms24 Lms24 enabled auto-merge (squash) January 15, 2024 16:02
@Lms24 Lms24 merged commit 64abebc into develop Jan 15, 2024
@Lms24 Lms24 deleted the lms/feat-core-deprecate-transaction-setMeasurement branch January 15, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants