Skip to content

feat(negroni): performance tracing#808

Merged
cleptric merged 2 commits intogetsentry:masterfrom
aldy505:feat/negroni/performance-tracing
Apr 11, 2024
Merged

feat(negroni): performance tracing#808
cleptric merged 2 commits intogetsentry:masterfrom
aldy505:feat/negroni/performance-tracing

Conversation

@aldy505
Copy link
Copy Markdown
Contributor

@aldy505 aldy505 commented Apr 3, 2024

Addresses #496

Tests will come at a later time (on this PR), probably next weekend.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 89.65517% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 81.91%. Comparing base (a6a7a20) to head (33de7b8).

Files Patch % Lines
negroni/sentrynegroni.go 89.65% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #808      +/-   ##
==========================================
+ Coverage   81.08%   81.91%   +0.83%     
==========================================
  Files          49       49              
  Lines        4087     4115      +28     
==========================================
+ Hits         3314     3371      +57     
+ Misses        632      601      -31     
- Partials      141      143       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aldy505 aldy505 marked this pull request as ready for review April 7, 2024 10:06
@aldy505
Copy link
Copy Markdown
Contributor Author

aldy505 commented Apr 7, 2024

cc @ribice @cleptric

@cleptric
Copy link
Copy Markdown
Member

cleptric commented Apr 8, 2024

Will merge this later this week.

@cleptric cleptric merged commit e6820d6 into getsentry:master Apr 11, 2024
@aldy505 aldy505 deleted the feat/negroni/performance-tracing branch April 11, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants