feat(starfish): add http.request.method attribute to span data#786
Merged
vaind merged 7 commits intogetsentry:masterfrom Mar 26, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #786 +/- ##
==========================================
- Coverage 82.04% 81.97% -0.08%
==========================================
Files 49 49
Lines 4846 4848 +2
==========================================
- Hits 3976 3974 -2
- Misses 729 732 +3
- Partials 141 142 +1 ☔ View full report in Codecov by Sentry. |
ribice
approved these changes
Mar 26, 2024
Contributor
Author
|
I suppose there'll be a merge conflict, but let's see |
ribice
approved these changes
Mar 26, 2024
vaind
approved these changes
Mar 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #713
Since existing performance tracing only available on net/http and gin, I only implement
http.request.methodattribute on those.