Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #699 +/- ##
=======================================
Coverage 80.78% 80.78%
=======================================
Files 44 44
Lines 4466 4466
=======================================
Hits 3608 3608
Misses 728 728
Partials 130 130 ☔ View full report in Codecov by Sentry. |
tonyo
approved these changes
Aug 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes sure
wg.Done()is called even if the test code in transport test fails.With the original code, a test failure in
testSendSignalEvent()would result in a timeout becausewg.Done()was never called and thus the subsequentwg.Fail()would get blocked indefinitely.In the new version, the actual test failure will be reported instead.