test: use mock transport to avoid many hanging worker routines#698
Merged
test: use mock transport to avoid many hanging worker routines#698
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #698 +/- ##
==========================================
- Coverage 80.85% 80.78% -0.07%
==========================================
Files 44 44
Lines 4466 4466
==========================================
- Hits 3611 3608 -3
- Misses 726 728 +2
- Partials 129 130 +1 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've noticed there are many HTTP transport worker goroutines running during tests (34 currently), and it was causing me some trouble when debugging profiling tests.
This PR reduces the use of actual HTTP transport to tests that need to test it. Replaces with mock transport elsewhere.
Unfortunately, I can't get rid of all the hanging goroutines because of how the HTTPTransport worker is implemented - there's no way to stop the routine at the moment.