fix: stack-trace in_app false being omitted#647
Merged
tonyo merged 2 commits intogetsentry:masterfrom Jun 5, 2023
Merged
Conversation
7 tasks
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #647 +/- ##
=======================================
Coverage 79.64% 79.64%
=======================================
Files 38 38
Lines 3896 3896
=======================================
Hits 3103 3103
Misses 683 683
Partials 110 110
☔ View full report in Codecov by Sentry. |
tonyo
approved these changes
Jun 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The stack trace in-app field had
omitemptyso it wouldn't be sent in JSON when it was false. This wasn't correct as that would actually lead to exactly the opposite behaviour in sentry.io where the frame would show asin-app=true(the default when the field is not present on the frame).