Codecov Report

Patch coverage: 57.40% and project coverage change: +0.37 🎉

Comparison is base (1b0b536) 79.64% compared to head (4d9ac48) 80.02%.

❗ Current head 4d9ac48 differs from pull request most recent head 5d5b4e4. Consider uploading reports for the commit 5d5b4e4 to get more accurate results

@@            Coverage Diff             @@
##           master     #644      +/-   ##
==========================================
+ Coverage   79.64%   80.02%   +0.37%     
==========================================
  Files          38       38              
  Lines        3896     3944      +48     
==========================================
+ Hits         3103     3156      +53     
+ Misses        683      675       -8     
- Partials      110      113       +3     

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Hey @zetaab , thanks for the changes 👍
Looks good; the only thing: could you add a test or two, to make sure it works as expected?

Could be something like https://github.com/getsentry/sentry-go/blob/master/http/sentryhttp_test.go, but can be even simpler (at least to make sure it doesn't crash).

@tonyo yeah I will do those, just take some days :)

@tonyo sorry for copy pasting the tests, but now its almost similar than in normal http lib. This does not include transaction tests. I will continue with those tomorrow.

actually it was quite easy to add transaction tests, so those are included now as well

Thanks, we'll take a closer look soon. For now, please revert any dependency bumps as we do not want to raise our base level.
Regarding Gin, you can read up on our Security Policy and why we do not force an upgrade from the SDK.

Thanks!