fix: Ensure <input type='submit' value='Btn text'> is masked#69
Merged
fix: Ensure <input type='submit' value='Btn text'> is masked#69
<input type='submit' value='Btn text'> is masked#69Conversation
This should be considered "Text", and should thus be masked by `maskAllText`.
<input type='button' value='Btn text'> is masked<input type='submit' value='Btn text'> is masked
billyvg
approved these changes
Feb 28, 2023
Comment on lines
+549
to
+550
| element, | ||
| element.tagName, |
Member
There was a problem hiding this comment.
l: We probably don't need both of these parameters
Member
Author
There was a problem hiding this comment.
yeah, I thought the same, wasn't sure - in one call site there is this getValidTagName method, not sure if we need this here...?
Member
Author
There was a problem hiding this comment.
We can always revisit this/clean this up later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should be considered "Text", and should thus be masked by
maskAllText.This is both for
<input type='button'>as well as<input type='submit'>.Closes #68