This repository was archived by the owner on Sep 17, 2024. It is now read-only.
feat(preprocessEvent): emit preprocessEvent for profiles #198
Merged
Conversation
mydea
approved these changes
Sep 19, 2023
src/integration.ts
Outdated
| const profile = createProfilingEvent(cpuProfile, profiledTransaction); | ||
|
|
||
| if (client.emit) { | ||
| // @ts-expect-error preprocessEvent hook doesn't exist? |
Member
There was a problem hiding this comment.
Weird, any idea why this does not exist here? Should be on both the client and Badeclient types 🤔
Member
Author
There was a problem hiding this comment.
I'll check, thought it might be because the changes are not in the latest release yet
Member
Author
There was a problem hiding this comment.
@mydea seems like it was just ts being cryptic due to the unknown Event.
19987da to
f0924d3
Compare
mydea
reviewed
Sep 20, 2023
src/integration.ts
Outdated
| if (client.emit && profile) { | ||
| const integrations = | ||
| // @ts-expect-error _integrations is private | ||
| typeof client._integrations === 'object' && |
Member
There was a problem hiding this comment.
Just a tip: you can use client['_integrations'] to access private fields without TS complaining.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements preprocessEvent hook implementation for profiles (counterpart to the replay PR)