metrics: metrics_local: Remove key argument to optimize performance#3473
Merged
Conversation
This is because our use cases doesn't need key for distinguish plugins and agents. One of the use cases to specify plugin_id calling has a possibility to become the bottleneck for performance. The reason is Kernel#instance_variable_defined? method is relatively heavy operation. Signed-off-by: Hiroshi Hatake <hatake@calyptia.com>
Contributor
|
I was just curious about it, how much performance is improved by this PR? |
kenhys
approved these changes
Jul 29, 2021
Contributor
Author
For synchronous output plugin case, 2x faster than the previous implementation. |
ashie
approved these changes
Jul 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Hiroshi Hatake hatake@calyptia.com
Which issue(s) this PR fixes:
Folows up #3440
What this PR does / why we need it:
This is because our use cases doesn't need key for distinguish plugins
and agents.
One of the use cases to specify plugin_id calling has a possibility to become the bottleneck for performance.
The reason is Kernel#instance_variable_defined? method is relatively
heavy operation.
Docs Changes:
No needed.
Release Note:
Same as title.