test: add tiny wait not to lose globbed entries#3316
Merged
Conversation
In busy loop, there may be a case that Dir.glob() lose existing entries under target directory. Above situation is observed with Ruby 3.0 on Windows. Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
Contributor
Author
It seems that the above error doesn't occur. |
ashie
approved these changes
Apr 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Related #3263
What this PR does / why we need it:
In busy loop with wait_flush, there may be a case that Dir.glob() lose
existing entries under target directory in some test cases.
As a result Timeout::Error: execution expired will be raised.
These failures in test/plugin/test_output_as_buffered_backup
are observed with Ruby 3.0 on Windows.
Docs Changes:
N/A
Release Note:
N/A