Fix an unstable test of in_tail (especially on macOS)#3314
Merged
Conversation
This commit try to fix the following failure:
2021-04-02T00:47:45.1133120Z Failure: test_truncate_file(TailInputTest)
2021-04-02T00:47:45.1140150Z /Users/runner/work/fluentd/fluentd/test/plugin/test_in_tail.rb:606:in `test_truncate_file'
2021-04-02T00:47:45.1140850Z 603: end
2021-04-02T00:47:45.1141130Z 604:
2021-04-02T00:47:45.1141450Z 605: events = d.events
2021-04-02T00:47:45.1141920Z => 606: assert_equal(3, events.length)
2021-04-02T00:47:45.1142440Z 607: assert_equal({"message" => "test3"}, events[0][2])
2021-04-02T00:47:45.1142960Z 608: assert_equal({"message" => "test4"}, events[1][2])
2021-04-02T00:47:45.1143490Z 609: assert_equal({"message" => "test1"}, events[2][2])
2021-04-02T00:47:45.1143940Z <3> expected but was
2021-04-02T00:47:45.1144370Z <1>
sleep time 1sec may too short when inotify isn't available or high load
situation.
Signed-off-by: Takuro Ashie <ashie@clear-code.com>
Member
Author
|
It seems become stable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
none
What this PR does / why we need it:
This commit try to fix the following failure:
sleep time 1sec may too short when inotify isn't available or high load situation.
Docs Changes:
none
Release Note:
none