test: mark Ruby 3.0 as experimental on windows#3307
Merged
Conversation
a872b65 to
2b79489
Compare
There are some failed unit test with Ruby 3.0 on windows, Instead of omitting those test cases, it may be better to mark "experimental" to clarify the issues. Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
2b79489 to
8326a69
Compare
ashie
requested changes
Mar 31, 2021
ashie
left a comment
Member
There was a problem hiding this comment.
continu-on-error is also needed:
fluentd/.github/workflows/macos-test.yaml
Line 18 in d19b706
Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
Contributor
Author
|
Thanks, I've added it. |
ashie
approved these changes
Mar 31, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Related #3263
What this PR does / why we need it:
There are some failed unit test with Ruby 3.0 on windows,
Instead of omitting those test cases, it may be better
to mark "experimental" to clarify the issues.
Docs Changes:
N/A
Release Note:
N/A